search

jonasmerlin / astro-seo

Makes it easy to add information that is relevant for SEO to your Astro app.
MIT License
908 stars 50 forks source link

Fix languageAlternate typo in README #81

Closed regisphilibert closed 10 months ago

regisphilibert commented 10 months ago

Key should be singular.

jonasmerlin commented 10 months ago

Hey @regisphilibert, thanks for your contribution!

The key is plural in the code (see here: https://github.com/jonasmerlin/astro-seo/blob/e03156f1c68917383d6bf2b02526405688a4d58b/src/SEO.astro#L30), that is because astro-seo can take an array of languageAlternates and then produce an alternate tag for each of them (see here: https://github.com/jonasmerlin/astro-seo/blob/main/src/components/LanguageAlternatesTags.astro)

So as far as I can tell, the README is correct, or am I missing something or misunderstanding your PR?

regisphilibert commented 10 months ago

Ah sorry about that, I suppose during my testing I confused localAlternate and languageAlternates as it's obvious I've been struggling judging by my commit message... :)

Thanks, I'll close this!

jonasmerlin commented 10 months ago

@regisphilibert No worries, I know where the confusion comes from. I actually struggled a bit with naming the attribute when implementing it and it would almost have been singular! 😄 Also, better this way than missing a fix. So thanks again and have a good one!