search

jonasmerlin / astro-seo

Makes it easy to add information that is relevant for SEO to your Astro app.
MIT License
908 stars 50 forks source link

Position of name and value makes it difficult to quickly read metatag values. #84

Closed mikeethedude closed 5 months ago

mikeethedude commented 9 months ago

I'm willing to submit a pull request for this.

Right now the extended tags (src/components/ExtendedTags.astro) output from this project output with the content before the name and that makes it difficult to parse at a glance.

      content={content}
      http-equiv={httpEquiv}
      media={media}
      name={name}
      property={property}
    />

I'd think it would make it easier if the name and property were the first attributes filled there.

jonasmerlin commented 9 months ago

@mikeethedude Thank you for your input! Since this input seems to stem from your experience with using this feature in your project(s), I would be more than happy to merge a pull request improving ergonomics this way. Please feel free to go ahead with this, and I'll put it into the next version!

mikeethedude commented 9 months ago

Awesome! Pull request is open. I think this is a pretty simple swap on properies. See https://github.com/jonasmerlin/astro-seo/pull/85

jonasmerlin commented 5 months ago

Landed in 0.8.1