search

jonasmerlin / astro-seo

Makes it easy to add information that is relevant for SEO to your Astro app.
MIT License
908 stars 50 forks source link

Link 'sizes' property is DOMTokenList type not string #87

Closed gvkhna closed 5 months ago

gvkhna commented 6 months ago

Here's an error:

Turns out HTMLLinkElement property 'sizes' is set to DOMTokenList which isn't meant to be serialized/deserialized. I think the best course of action is to override the type to string.

Screenshot 2024-01-31 at 10 28 48 AM
jonasmerlin commented 5 months ago

Hey @gvkhna, thank you for reporting this. Would you be willing to submit a PR for this?

gvkhna commented 5 months ago

That should be all that is needed but there is lack of instructions for building/testing and I don't have time to work on this further. If you can take a look that would be great. Thanks!

gvkhna commented 5 months ago

Thanks works great!