search

jonasoreland / runnerup

A open source run tracker
GNU General Public License v3.0
753 stars 275 forks source link

Target SDK 34 #1176

Closed gerhardol closed 5 months ago

gerhardol commented 8 months ago

registerReceiver() updates

roberi commented 8 months ago

Nice work! But you missed the onBackPressed() in UploadActivity.

gerhardol commented 8 months ago

I have briefly run this on A12 and A9 too. Can maybe make a public beta next weekend.

roberi commented 8 months ago

Seems to work on my Pixel 6 (A14) as well.

But one thing to keep in mind in future updates (for example after replacing TabActivity in #648)... For the new "predictive back animations" to work as intended, we should disable a OnBackPressedCallback instead of eg. calling finish() in the callback. So eg. in the DetailActivity the callback should only be enabled (intercept back navigation) while uploading.

gerhardol commented 8 months ago

Seems to work on my Pixel 6 (A14) as well.

But one thing to keep in mind in future updates (for example after replacing TabActivity in #648)... For the new "predictive back animations" to work as intended, we should disable a OnBackPressedCallback instead of eg. calling finish() in the callback. So eg. in the DetailActivity the callback should only be enabled (intercept back navigation) while uploading.

The back navigation is adjusted to go to StartActivity when back in Settings as some other tweaks like disabling back in Run and just disabling GPS when it has been restarted. For instance the last requires some other way to disable GPS. So this is the fix for updating, not the functionality adopted to A14. I do not require that the app works as it does now, most changes are improvements...

roberi commented 8 months ago

Thanks for the clarification. I´m looking forward to try the new bete when you have time to publish it. Also if/when you merge this PR, I can include it in my work in replacing TabActivity.

gerhardol commented 7 months ago

When using this I saw an activity being paused just after starting. That was probably accidentally done when putting away the phone but I want some more usage...

gerhardol commented 5 months ago

A few other changes added to this PR

To be able to push an update in Play, Wear must be disabled.

Google Play requires update from the ancient play wear version, which requires migration to the ancient (non-bundled) wear interface. The wear app was not built as it was and had to be sideloaded on the watch. It is possible to revert the patch and download in the phone to continue to use Wear. (I do not have any Wear device and cannot do the migration.)