search

jonasrauber / eagerpy

PyTorch, TensorFlow, JAX and NumPy — all of them natively using the same code
https://eagerpy.jonasrauber.de
MIT License
695 stars 40 forks source link

implementation of `slogdet` in eagerpy #27

Closed eserie closed 3 years ago

eserie commented 3 years ago

Would you consider to add or accept a contribution to add and implementation of slogdet function (see for ex the numpy implementation)?

jonasrauber commented 3 years ago

Sure. How do you intend to implement that in PyTorch and TensorFlow?

eserie commented 3 years ago

Here are the implementations for pytorch, tensorflow and jax.

jonasrauber commented 3 years ago

Sounds good, feel free to open a PR

eserie commented 3 years ago

Ok, thanks @jonasrauber, I'm catching the development workflow and I should soon propose a PR on which we should iterate to accommodate style, testing etc...

eserie commented 3 years ago

Hi @jonasrauber, I proposed the PR #28. Let me know if you think something should be done differently. Thanks.