search

jonasrauber / eagerpy

PyTorch, TensorFlow, JAX and NumPy — all of them natively using the same code
https://eagerpy.jonasrauber.de
MIT License
695 stars 40 forks source link

correct implementation of ndim ... #40

Closed eserie closed 3 years ago

eserie commented 3 years ago

... in order to work in compile mode with tensorflow (see issue https://github.com/tensorflow/tensorflow/issues/48612 and https://github.com/jonasrauber/eagerpy/issues/36)

TODO: add a specific test for the usage of tf.function?

codecov[bot] commented 3 years ago

Codecov Report

Merging #40 (4bf7908) into master (4656839) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #40   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1753      1753           
=========================================
  Hits          1753      1753
Impacted Files Coverage Δ
eagerpy/tensor/base.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4656839...4bf7908. Read the comment docs.

jonasrauber commented 3 years ago

Thanks!

If you want to add a specific test for the usage of tf.function (to ensure that feature changes stay compatible with tf.function), feel free to open another PR.

eserie commented 3 years ago

Thanks!

If you want to add a specific test for the usage of tf.function (to ensure that feature changes stay compatible with tf.function), feel free to open another PR.

Sure, I'll do so! I just have to think about how integrate such a specific test in the current test code base since currently it seems that we systematically test all backends.