search

jonasroussel / dart_jsonwebtoken

A dart implementation of the famous javascript library 'jsonwebtoken'
MIT License
87 stars 29 forks source link

Include tests #47

Closed alestiago closed 1 year ago

alestiago commented 1 year ago

Description

There are currently no tests, as a user of the package I would like the package to be well and fully tested. Mainly to ensure the code consistently works and no unexpected breaking changes are pushed.

Requirements

Further context

This package is currently being recommend as part of a Dart Frog tutorial. It would be ideal if this package had test to guarantee a certain level of quality.

Thanks for the package, would you be willing to accept external contributions that add tests to the codebase?

jonasroussel commented 1 year ago

Hey @alestiago !

I didn't know that Dart Frog recommended this package, very glad to hear it!

External contributions are always welcome! I'll try to set up a some tests by the end of the week and after that you'll be able to add your own tests to reach 100% of test coverage.

I've already started a workflow to auto-deploy the package, at the same time I'll make one more to run the tests.

jonasroussel commented 1 year ago

@alestiago

I wanted to let you know that I've just set up the first tests. These are still basic tests that only test the 2 main functions sign & verify with all available algorithms but I may add more soon, you're also free to add your own.

In the meantime, I've created 2 GH actions: one that will analyze the code (formatting & litering) and run tests for each new PR and PR change, and another that will publish the package on the new tags (also running the CI analyze and test beforehand).