jonassanoj / dbpro

DB Project 1
19 stars 1 forks source link

question_model: implement the filter function so that it works as documented. #55

Closed tilman-schieber closed 12 years ago

tilman-schieber commented 12 years ago

models/question_model.php

line 89: implement the filter function so that it works as documented.

tilman-schieber commented 12 years ago

Please note that I have recently changed the documentation of the filter array so it can also contain:

 fieldID: show only questions of a category that belong to a specific field id

I needed this for another task I added. For your task it is now optional to implement this feature. If you have the time however feel free to implement the $fieldID part. Hint: use a subquery that returns all categoryIDs and check for set membership.

ashraftanin commented 12 years ago

Hello Sir,

I am implementing the filter function like in attachment, I am not
sure that I am in right way or not, because before this I worked on
Design part, I am a little unfriendly with this part. please confirm
me If I am in the right way, otherwise please write me some hint if
possible.

regards

Quoting tilman-schieber
reply@reply.github.com:

Please note that I have recently changed the documentation of the
filter array so it can also contain:

 fieldID: show only questions of a category that belong to a  

specific field id

I needed this for another task I added. For your task it is now
optional to implement this feature. If you have the time however feel free to implement the $fieldID part. Hint: use a subquery that returns all categoryIDs and check for
set membership.


Reply to this email directly or view it on GitHub: https://github.com/jonassanoj/dbpro/issues/55#issuecomment-6376017

tilman-schieber commented 12 years ago

Just look at the documentation of the filter function and implement it like it is documented. We can postpone passing fieldID for now as you need a subquery and this can't be realized with the current interface. The rest of the implementation should be easy: Basic PHP array functions and the documentation of the $this->db->where() activerecord class should be enough to get you started.

Look here: http://php.net/manual/de/function.array-key-exists.php and here: http://codeigniter.com/user_guide/database/active_record.html

On Sun, Jun 17, 2012 at 11:37 AM, ashraftanin reply@reply.github.com wrote:

Hello Sir,

I am implementing the filter function like in attachment, I am not sure that I am in right way or not, because before this I worked on Design part, I am a little unfriendly with this part. please confirm me If I am in the right way, otherwise please write me some hint if possible.

regards

Quoting tilman-schieber reply@reply.github.com:

Please note that I have recently changed the documentation of the filter array so it can also contain:

     fieldID: show only questions of a category that belong to a specific field id

I needed this for another task I added. For your task it is now optional to implement this feature. If you have the time however feel free to implement the $fieldID part. Hint: use a subquery that returns all categoryIDs and check for set membership.


Reply to this email directly or view it on GitHub: https://github.com/jonassanoj/dbpro/issues/55#issuecomment-6376017


Reply to this email directly or view it on GitHub: https://github.com/jonassanoj/dbpro/issues/55#issuecomment-6379993

ashraftanin commented 12 years ago

Hello Sir, The filter function implemented, unfortunately due to my computer problem, I couldn't test it, if it has problem just notify me here and I will work on again!

tilman-schieber commented 12 years ago

Parse error: syntax error, unexpected T_OBJECT_OPERATOR in models\question_model.php on line 98

I dont get it. Just use eclipse.... it will show you mistakes like this without even running a web server and a web server is also not so hard to run

the mistake is this instead of $this

if you commit something like this you will break the project for EVERYONE pulling the repository. And you commited your private configuration files with your root password. please follow the instructions in the wiki to prevent this

Thank you!

tilman-schieber commented 12 years ago

works as intended. A bit sad you didnt try to implement the field part but it's okay But don't commit a broken version again, please