search

jonassanoj / dbpro

DB Project 1
19 stars 1 forks source link

controller/user: Document functions and modify failed() #69

Closed tilman-schieber closed 12 years ago

tilman-schieber commented 12 years ago

controller/user.php line 50

Document the login(), logout() and failed() function using phpdoc-comments. Change the implementation of failed() so it accepts only 3 failed logins. After the third try the user should be sent to the recover page (user/recover/$username).

ahmadnawid commented 12 years ago

You reset my code in controller main.php First pull the changes and then commit yours.

tilman-schieber commented 12 years ago

i dont think so neither you nor ahmadzai did commit changes to main.php check the version history to confirm https://github.com/jonassanoj/dbpro/commits/master/application/controllers/main.php

ahmadzai commented 12 years ago

i think i didn't bring any changes in main.php, i have commit and push my work, which was in the user.php (controller) just (login, logout and failed methods),

tilman-schieber commented 12 years ago

probably not but you complained about changes to main.php. thats why i checked it. the changes commited by "root" were made by Huma and she made changes to the Model only. user.php however also only has commits by you so I don't really see your problem

ahmadzai commented 12 years ago

yeah thank you Sir, now i am going to close this issue

tilman-schieber commented 12 years ago

Well documented, but why did you document this using html tags in the source code? this is confusing. use markdown markup if you need highlighting

ahmadzai commented 12 years ago

I have used HTML tags to generate (list) unorderd list, its looking very nice Sir, and its common to use html tags in java-doc, or php-doc, in eclipse, and it has built-in support for html :o

tilman-schieber commented 12 years ago

i know what the tags do its unreadable in source code for lists you use

this is automatically converted in a html list on parse and is actually readable by everybody with the same result

On Thu, Jun 21, 2012 at 3:25 PM, Wazir Khan reply@reply.github.com wrote:

I have used HTML tags to generate (list) unorderd list, its looking very nice Sir, and its common to use html tags in java-doc, or php-doc, in eclipse, and it has built-in support for html :o

Reply to this email directly or view it on GitHub: https://github.com/jonassanoj/dbpro/issues/69#issuecomment-6482035