search

jonasschmidt / ex_json_schema

An Elixir JSON Schema validator
MIT License
366 stars 98 forks source link

Add dialyzer and fix specs #31

Closed hzamani closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 100.0% when pulling 0840c2f0b7199464384cd7fb98e760a070fa592e on hzamani:specs-and-dialyzer into ad86d4482a8bda66ba9e6dc954b69261051047bf on jonasschmidt:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 100.0% when pulling 0840c2f0b7199464384cd7fb98e760a070fa592e on hzamani:specs-and-dialyzer into ad86d4482a8bda66ba9e6dc954b69261051047bf on jonasschmidt:master.

jonasschmidt commented 6 years ago

Nice! Thanks for taking care of that. Any ideas why the build is still failing for Elixir 1.4.5 with OTP 18.3? I can merge the PR once everything's green.

odk211 commented 6 years ago

Related? https://github.com/elixir-lang/elixir/issues/6046

jonasschmidt commented 6 years ago

Definitely looks like a known issue, thanks for digging that up @odk211. I will merge the PR and exclude the Elixir 1.4.5/OTP 18.3 combination from the build matrix.