expands dialyzer definition, it was incomplete if you resolve something that is an edge node.

jonasschmidt / ex_json_schema

An Elixir JSON Schema validator

MIT License

366 stars 98 forks source link

expands dialyzer definition, it was incomplete if you resolve something that is an edge node. #57

Closed mogorman closed 4 years ago

mogorman commented 4 years ago

for example I am using the libary like so

ExJsonSchema.Schema.get_fragment(spec, [
             :root,
             "paths",
             path,
             method,
             "requestBody",
             "required"
           ])

which returns

{:ok, true}

which violates spec. this pr fixes the spec definition.

coveralls commented 4 years ago

Coverage remained the same at 98.696% when pulling a01daec0f49977c843fb1b053b138601e23be713 on mogorman:fix_dialyzer into 1f7d2cd424449ec2b4272c7e1c6f28f57f09abd6 on jonasschmidt:master.

coveralls commented 4 years ago

Coverage remained the same at 98.696% when pulling a01daec0f49977c843fb1b053b138601e23be713 on mogorman:fix_dialyzer into 1f7d2cd424449ec2b4272c7e1c6f28f57f09abd6 on jonasschmidt:master.

jonasschmidt commented 4 years ago

Good catch! Thank you for fixing that 👍

jonasschmidt commented 4 years ago

Published as version 0.7.4 🚀