search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
553 stars 130 forks source link

use '-' as words separator #131

Closed marojenka closed 4 years ago

marojenka commented 5 years ago

Fix wrong word separator in box-max-width and box-max-width data attributes. In python '_' is used so it lead to a missprint. '-' is chosen for consistency with rest of frontend. Without this IMAGE_CROPPING_THUMB_SIZE option makes no effect.

MRigal commented 4 years ago

Thanks for your contribution @marojenka ! Would you like to rebase your branch so that we could integrate it?

marojenka commented 4 years ago

hello, some time passed and I don't have proper environment to check if it's still valid but judging only from commits it should be.

I did rebase and force pushed into my branch but this PR was not updated. Not sure what I expected. Should I make new PR?

MRigal commented 4 years ago

Hi @marojenka sorry I've played a bit with your branch as I wasn't having the same issues as I am a collaborator. At the beginning, it was not triggering the action at all on your branch and then only on your branch and not in the PR. I had to modify a setting on the action definition. Now it works, thanks for the contribution @marojenka !