search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
553 stars 130 forks source link

ImageCroppingMixin - formfield_for_dbfield miss request from arguments #134

Closed bmihelac closed 4 years ago

bmihelac commented 4 years ago

formfield_for_dbfield should include request positional argument, otherwise it can fail with error below when this library is used with some other that also overrides formfield_for_dbfield (django-modeltranslation is one example)

TypeError: formfield_for_dbfield() takes 2 positional arguments but 3 were given

ref:

https://code.djangoproject.com/ticket/25985 https://github.com/django/django/commit/dbb0df2a0ec5bee80bee336fc81408efb30b7e47

nortigo commented 4 years ago

Any update?