search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
553 stars 130 forks source link

fix: add request to formfield_for_dbfield signature (#134) #135

Closed bmihelac closed 4 years ago

bmihelac commented 4 years ago

I see, that django-image-cropping supports older Django. I'll update to accomodate this ASAP

nortigo commented 4 years ago

Any updates?

MRigal commented 4 years ago

@bmihelac you're right, the signature is not up-to-date. Would you like to rebase on the actual master, also to incorporate the latest super() call?

bmihelac commented 4 years ago

@MRigal sure, would do it as soon as I catch some time

bmihelac commented 4 years ago

This has been rebased to master, please let me know if anything else is needed.

MRigal commented 4 years ago

Thanks @bmihelac for the contribution! I'll wait on feedback on https://github.com/jonasundderwolf/django-image-cropping/issues/140 to merge #148 and release a new version! :-)

bmihelac commented 4 years ago

@MRigal thanks for quick action :)