search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
552 stars 131 forks source link

Fix admin widget in django 3.0 #137

Closed saemideluxe closed 4 years ago

saemideluxe commented 4 years ago

This is a small patch in order to allow using the admin widget with django 3.0. The intention was to change as little as possible while keeping backward compatibility.

saemideluxe commented 4 years ago

Also fixes #136

Mogost commented 4 years ago

In fact, with adding support for django 3.0, we need to drop support for Py2. easy-thumbnails does the following things simultaneously in the next release

This PR is completely unprepared for a merge. Sorry, you haven’t even added Django 3.0 to the test matrix.

Also, django 3.0 docs:

Third-party library support for older version of Django¶ Following the release of Django 3.0, we suggest that third-party app authors drop support for all versions of Django prior to 2.2. At that time, you should be able to run your package’s tests using python -Wd so that deprecation warnings appear. After making the deprecation warning fixes, your app should be compatible with Django 3.0.

Mogost commented 4 years ago

Of course, none of us is an author, and probably I would like to hear an opinion from @anrie @escaped and @ptrck

anrie commented 4 years ago

I completely agree with @Mogost

Adding Django 3 to the test matrix should hopefully show all the things that need to be considered.

It would we great if this PR could be enhanced to add the missing pieces for a release that is compatible with Django 3.0.

For me it would be okay to follow easy-thumbnails and issue a release that drops support for Django < 2.2.

If I see it correctly that would also render the initial issue in this PR obsolete.

saemideluxe commented 4 years ago

This PR is completely unprepared for a merge. Sorry, you haven’t even added Django 3.0 to the test matrix.

Sorry, the title must have been a bit misleading (will change that in a minute). My intention was not to migrate the project to django 3.0 but to fix the issue with the admin-widget in django 3.0.

@anrie Right now I think I have no time to work on this on my own. I quickly tried tox with django30 and at least one other issue comes up (which is related to django-webtest). Is there a way other people can contribute to a PR? @Mogost could update the tox/travis configuration which I am not used to. Then we could work on fixing the remaining issues, I guess it is mostly dependency issues.

Mogost commented 4 years ago

In fact, we are not in a hurry, in any case, the release with Django 3.0 support of easy-thumbnails has not yet taken place at the moment. If I have time, I will do PR. In any case, if someone is ready to do it faster than me - please. I will then be ready to do a review.

Mogost commented 4 years ago

139

Done

anrie commented 4 years ago

I merged @Mogost compatibility branch and issued a new release: https://pypi.org/project/django-image-cropping/ Hope that solves all the issues :-)