search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
553 stars 131 forks source link

Cropping shown double on EditView and not at all on CreateView #44

Closed philippeluickx closed 10 years ago

philippeluickx commented 10 years ago

Hey,

Just been struggling in getting this package implemented... I managed to have crop through admin up and running, but having issues with implementing it in my ModelForm.

Currently it shows twice the cropping under each other on EditView and it only shows title and no cropping on CreateView... I do not have the impression I use anything funky, except crispy-forms. But even flukes when I do not apply crispy.

Running django 1.6.2 and django-image-cropping trunk.

Thanks for your help!

anrie commented 10 years ago

Hey Philippe,

without seeing any code or concrete examples it's really hard to tell what is going on. Did you check the modelform example and spot any differences? (Apart from the fact that you are using class based views ;-))

However if it's not a simple syntax problem it would be great if you could create a test case that demonstrates the issue so we have starting point to fix the problem.

philippeluickx commented 10 years ago

Hey!

Found out at least the first part. The doubles showing is just that I was importing

{{ form.media.css }}

{{ form.media.js }}

in my base template... Seems like that duplicates the croping image.

Remains the Createview, although I was considering that it has probably more to do with the fact that no image is uploaded yet. How would I be able to use imagecropping through a Createview best? Would that be through ajax somehow?

philippeluickx commented 10 years ago

Closing this for now, would be glad to hear if there is a way to use this during creation of an image!

kuanyui commented 9 years ago

I also wonder if there any way to use image cropping in CreateView. Is there any progress?

wanaryytel commented 9 years ago

I too tried to implement it in CreateView, needless to say without success. Waiting for some hints as well.

anrie commented 9 years ago

As discussed in another Issue (#61) it would be nice if we could leverage the FileReader-API for our cropping concerns. That would allow us to crop images without saving them first, which seems to be the problem with the CreateView.

As we use Image Cropping mainly in the backend this is not a top priority for us, but it would of course be great if someone would come up with Pull Request for this feature.