search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
552 stars 131 forks source link

Fixes for Django 1.9 #82

Closed andy128k closed 8 years ago

jonasvp commented 8 years ago

Thanks for the PR! Unfortunately, we need to support older Django versions as well, so we'd need to use something like https://github.com/wq/django-swappable-models/pull/9/files

andy128k commented 8 years ago

@jonasvp Do you have to support Django 1.6 or earlier?

jonasvp commented 8 years ago

Good question. @anrie?

anrie commented 8 years ago

Though we dropped explicit tests for older versions I think the current release (1.0.2) should run on newer versions than Django 1.4.

Regarding Django 1.9 you should also consider this discussion: https://github.com/jonasundderwolf/django-image-cropping/issues/80 On my machine the selenium test are currently a bit shaky and I didn't have time to look into it so I can't tell for sure if there are still issues to be resolved.

anrie commented 8 years ago

I just published a new version that incorporates the necessary fixes for 1.9: https://pypi.python.org/pypi/django-image-cropping/1.0.3