search

jonasundderwolf / django-image-cropping

Django helper application to easily and non-destructively crop arbitrarily large images in admin and frontend.
Other
552 stars 131 forks source link

Max height and width for large images not working #95

Closed userdefinable closed 4 years ago

userdefinable commented 8 years ago

Setting maximum height and width of large images is not working. I believe this is owing to undefined boxHeight and boxWidth due to incorrect variable names.

django-image-cropping/image_cropping/static/image_cropping/image_cropping.js

lines 57 to 61

$this.data('box_max_width') should be $this.data('box-max-width') in two occurrences

$this.data('box_max_height') should be $this.data('box-max-height') in two occurrences

anrie commented 8 years ago

@userdefinable

Could you provide a PR (ideally with a test) for the issue?

MRigal commented 4 years ago

Hi @userdefinable Time has passed, but could you eventually confirm that the PR #131 has fixed your issue?

MRigal commented 4 years ago

Time to close this. Please re-open if it wasn't fixed @userdefinable