search

jonaswouters / XhprofBundle

XHProf bundle for Symfony 2
210 stars 49 forks source link

Use XhprofDetail Entity in the Collector #15

Closed jeremymarc closed 12 years ago

baldurrensch commented 11 years ago

@jeremymarc What was the rationale from changing this from the native query to a doctrine entity? This is slower now. Besides that it broke existing functionality. The entity does NOT correspond with what is in https://github.com/preinheimer/xhprof/blob/master/xhprof_lib/utils/Db/Mssql.php#L9

jeremymarc commented 11 years ago

better integration with symfony framework (./app/console etc.)

baldurrensch commented 11 years ago

So does that then mean that people have to change their database schema for xhprof and deviate from what is standard?

jeremymarc commented 11 years ago

I was talking about the first question. For the second, fell free to send a PR or I will do it later.

jonaswouters commented 11 years ago

Maybe we could make it optional?

baldurrensch commented 11 years ago

Or pass the FQ name-spaced class name as a parameter in, and provide one with the bundle. Then it would be easy to replace it.