search

jonaswouters / XhprofBundle

XHProf bundle for Symfony 2
210 stars 49 forks source link

Xhprof detail table and mysql >=5.6 #29

Closed stephpy closed 11 years ago

stephpy commented 11 years ago

Hi, since this bundle use an Entity definition and not MappedSuperclass, launching schema-update command will insert the details table in mysql.

But there is a big mistake on this table, xhprof called a column get which is a reserved words on mysql 5.6.

I'm not sure if there is solution planified at this moment from xhprof team but we could transform the entity as mapped superclass to avoid automatic creation of this one even if we don't care about.

User'll have to create an Entity which extends the superclass to benefits of details table (if he's on mysql < 5.6).

I can make a PR if you're ok. @gissues:{"order":50,"status":"notstarted"}

jeremyFreeAgent commented 11 years ago

:+1:

stephpy commented 11 years ago

Oops, bad handling. Any news on this ?

I created an issue on xhprof repository: https://github.com/preinheimer/xhprof/issues/69

jonaswouters commented 11 years ago

I'm fine with it.

:)

stephpy commented 11 years ago

I'll make a PR for superclass doctrine asap.