search

jonaswouters / XhprofBundle

XHProf bundle for Symfony 2
210 stars 49 forks source link

support console command profiling #44

Closed dbu closed 10 years ago

dbu commented 10 years ago

hi, i needed console profiling. for now, i just slapped together a console event listener (symfony 2.3+) but if you are interested, i can do a pull request.

the code at https://github.com/dbu/XhprofBundle/blob/master/DataCollector/XhprofCollector.php#L52 is checking something about cli - is that working already?

if you want, we need to agree how to refactor the code as on console there is no request. XhprofCollector could provide entry points for the console. we could have separate configuration for the console too, or use the same (for the exclude patterns at least, a separate config makes more sense)

stephpy commented 10 years ago

Hi,

Yep, it would be a good improvement !

I'm almost sure than XhprofCollector CLI not work (never tested). May be it works by injecting a Request object created into the command but it's not the good solution.

We're open to any refactoring/idea to improve this bundle, thanks ;)