search

jonaswouters / XhprofBundle

XHProf bundle for Symfony 2
210 stars 49 forks source link

add console listener and do some cleanup #45

Closed dbu closed 10 years ago

dbu commented 10 years ago

fix for #44

I warned you, ended up doing quite some refactoring. Both console and web requests still work in my installation (symfony 2.3).

stephpy commented 10 years ago

Awesome work, thanks.

We'll take a look at bad documented things.

dbu commented 10 years ago

great. i recommend you test the changes with your use cases to see if i broke anything (i did not use the doctrine integration for example)

regarding the doc on the header: i would opt to change the code rather than the doc - sending the link is more userfriendly than just the id i guess.

stephpy commented 10 years ago

I do not use doctrine integration too :\ Theses changes works for my use case. I don't see any reason why this PR would break doctrine integration here.

+1 on header doc.