search

jonaswouters / XhprofBundle

XHProf bundle for Symfony 2
210 stars 49 forks source link

Split collectors, add aggregate collector, rename xhgui #50

Closed ShonM closed 10 years ago

ShonM commented 10 years ago

Wasn't sure how to title this set of changes, but I will describe them:

This PR renames XHGui to XHProf.io which is more inline with the documentation. XHGui is another, separate project that used to share its name - this has been clarified. The default XHProf implementation was added. An aggregate collector is present which is the default collector for requests and console commands which supports collecting to many child collectors. A compiler pass controls which collectors are tagged with data_collector, by default disabling unused collectors from polluting the container which might only be useful in some scenarios, but was for me because I'm not always using them in every environment. Lean containers just feel nice :)

I think that's it! Critique is 110% welcome, but I can't promise I'll have time to implement any suggestions, although I will do my best.

ShonM commented 10 years ago

I just added another commit that changes the behavior a bit, to disable the entire bundle when xhprof is not available. It aligns with my own needs, but I can understand if that's not a desirable result that it's essentially a silent failure.

stephpy commented 10 years ago

Hi, thanks, i'll take a look at this PR asap. Looks good. :)

jonaswouters commented 10 years ago

@stephpy did you have a look at this?

stephpy commented 10 years ago

Nope, i haven't time :.

It has to be rebased too.

ShonM commented 10 years ago

Need anything from me to get this in?

stephpy commented 10 years ago

It has to be rebased.

ShonM commented 10 years ago

Unfortunately I don't have the time for that currently. Happy to work with anyone who does.