Closed ShonM closed 10 years ago
I just added another commit that changes the behavior a bit, to disable the entire bundle when xhprof is not available. It aligns with my own needs, but I can understand if that's not a desirable result that it's essentially a silent failure.
Hi, thanks, i'll take a look at this PR asap. Looks good. :)
@stephpy did you have a look at this?
Nope, i haven't time :.
It has to be rebased too.
Need anything from me to get this in?
It has to be rebased.
Unfortunately I don't have the time for that currently. Happy to work with anyone who does.
Wasn't sure how to title this set of changes, but I will describe them:
This PR renames XHGui to XHProf.io which is more inline with the documentation. XHGui is another, separate project that used to share its name - this has been clarified. The default XHProf implementation was added. An aggregate collector is present which is the default collector for requests and console commands which supports collecting to many child collectors. A compiler pass controls which collectors are tagged with data_collector, by default disabling unused collectors from polluting the container which might only be useful in some scenarios, but was for me because I'm not always using them in every environment. Lean containers just feel nice :)
I think that's it! Critique is 110% welcome, but I can't promise I'll have time to implement any suggestions, although I will do my best.