search

jonaswouters / XhprofBundle

XHProf bundle for Symfony 2
210 stars 49 forks source link

[feature] Use sanitized uri as source instead of 'Symfony' #56

Closed olaurendeau closed 10 years ago

olaurendeau commented 10 years ago

This replace source part of the files generated by Xhprof. For now files are named like : "539029914bbb1.Symfony.xhprof", which is not really explicit when looking for a run. With those changes for this url : 

http://www.mydomain.com/path/to/my/page?__xhprof&some_query_parameter=some_value

run filename will look like 

53903af058742.http-~www-mydomain-com~path~to~my~page-__xhprof-some_query_parameter-some_value.xhprof

Which is not perfect but more understandable when looking the run list

olaurendeau commented 10 years ago

up

stephpy commented 10 years ago

Thanks ;)

olaurendeau commented 10 years ago

Welcome :) What's your release process ? Do you think to draft a tagged version soon ?

stephpy commented 10 years ago

I created a new version 1.0.2.

I think new features are not so important, so i didn't pass to 1.1.0 (using semver).

olaurendeau commented 10 years ago

Thanks. No I don't think so.

By the way I think it would be more sustainable to have a unit testing system and CI configured for the bundle. I would have been glad to implement some unit tests, but as there was neither phpunit or phpspec or other, I didn't know which one you prefer.

stephpy commented 10 years ago

Yep, big :+1:. I guess phpunit is the standard, but if you're more confortable with phpspec, no problem.

jonaswouters commented 10 years ago

For me both are fine. phpspec is a bit easier on the eyes though.