Closed ryabenko-pro closed 9 years ago
Hey @ryabenko-pro
Looks like the xhprof extension is not enabled in your environment. Take a look at this pull request and let me know if you have any questions https://github.com/jonaswouters/XhprofBundle/pull/61
@stephpy Do you think this was a bad change? We can always roll back
Same for me. Some developers have xhprof, some not. Solve it by move enabled to params, but it is ugly on my mind.
Maybe better to have something "strict_enabled", or "check_extension_exists"
@ewgRa feel free to add it and do a pull request :)
Or perhaps revert the changes? https://github.com/jonaswouters/XhprofBundle/pull/72
I don't know how author follow BC changes. On my mind #61 broke BC. But for now revert it - broke it again. Since there is one year left, I prefer not to revert it, but add require_extension_exists: true by default.
In this case there is no BC, but I and others will have ability to skip this requirement. And just render in profiler something like "Disabled due to extension not exists".
If this good idea, I can make pull request, no problem.
Sure, pull request welcome.
Pull request for this #73
Pull request accepted
This is kinda strange. It was working fine, but today after I run
composer self-update
and thencomposer install
I've got this issue: