[Android Bootcamp] Week 2 Project: GoogleImageSearch-App Ready for Review

[jonaswuAndroidBootCamp]

My app is complete, please review, thanks~~~. /cc @nidhi1608 @thecodepath

[codepathreview]

:+1: Excellent work again this week. A few notes after checking out the code:

• Great work on organizing source code.
• Nice to see you used action bar for searching
• Good job on getting the Share functionality working
• Great job implementing DialogFragment for filters.
• Good job using the ConnectivityManager to check for network availability
• Great job using staggered grid view for polishing the app UI.
• Great job on getting panning and zooming work
• General comment: clean and modularized code, great job on that
• One thing to consider is rather than saving all values separately as keys, you might have introduced a parcelable model representing all the filters and then you can store it or pass it around.

We have provided a detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be very important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.

[jonaswuAndroidBootCamp]

Hi @nidhi1608, @codepathreview, thanks for your thoroughly review and feedback.

I just push with a code change to use spinner as a single choice ui component instead of my old design via set of checkbox for color/imgtype filter setting, for it seems being good for both UI layout and code maintenance. Also, following by your great post about Heterogenous ListView, finally I realize and solve a bothering problem for why convertView of child views are always reused across group view of ExpandableLisView for it block the usage of ViewHolder + Different child layout on ExpandableListView, and successfully apply the Heterogenous interface + ViewHolder pattern on ExpandableListView to achieve different child layout across group. See demo. Thanks again for your nice post~!