jonatan-ivanov / teahouse

Sample applications to demonstrate Observability concepts
224 stars 72 forks source link

Random Vogon fixes #12

Closed vanam closed 2 months ago

vanam commented 2 months ago

Hi, firstly, I would like to thank you for this amazing demo.

There are several minor improvements which might make your demo one bit more amazing.

So Long, and Thanks for All the Fish

vanam commented 2 months ago

Strange thing happens when I run ./gradlew resolveAndLockAll --write-locks. Every time it messes up some org.jetbrains.kotlin dependencies.

It turns

org.jetbrains.kotlin:kotlin-stdlib-common:2.0.0=compileClasspath,productionRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.24=compileClasspath,productionRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24=compileClasspath,productionRuntimeClasspath,runtimeClasspath,testCompileClasspath,testRuntimeClasspath

to

org.jetbrains.kotlin:kotlin-stdlib-common:2.0.0=compileClasspath,testCompileClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.24=compileClasspath,testCompileClasspath
org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24=compileClasspath,testCompileClasspath

and then ./gradlew build fails:

Execution failed for task ':tea-service:cyclonedxBom'.
> Could not resolve all dependencies for configuration ':tea-service:runtimeClasspath'.
   > Resolved 'org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.9.24' which is not part of the dependency lock state
   > Resolved 'org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.9.24' which is not part of the dependency lock state
   > Resolved 'org.jetbrains.kotlin:kotlin-stdlib-common:2.0.0' which is not part of the dependency lock state

I have to manualy remove this change from changelist. Is it also happening to you?

jonatan-ivanov commented 2 months ago

Strange thing happens when I run ./gradlew resolveAndLockAll --write-locks. Every time it messes up some org.jetbrains.kotlin dependencies. [...] I have to manualy remove this change from changelist. Is it also happening to you?

Unfortunately it does, I think this is caused by okhttp that uses the Kotlin SDK, it's on my list to fix it, I created an issue to track it: https://github.com/jonatan-ivanov/teahouse/issues/13 I'm not a fan of having the Kotlin SDK on the classpath anyways so this can mean replacing okhttp (maybe OpenFeign too) for the new Interface Clients in Spring Framework but I need to check if instrumentation works with the customizations I have and if there is Logbook support available.

vanam commented 2 months ago

I guess we can close this PR now.

jonatan-ivanov commented 2 months ago

Thank you very much!

jonatan-ivanov commented 2 months ago

Superseded by

jonatan-ivanov commented 2 months ago

I think the merged PRs and these commits:

Thank you very much once again for the contributions!