jonatanklosko / wca_statistics

Build kit for generating cubing-related rankings
https://jonatanklosko.github.io/wca_statistics
MIT License
18 stars 29 forks source link

worst_result_on_podium not counting singles in ao5/mo3 events. #12

Closed toadfrommariokart64 closed 2 years ago

toadfrommariokart64 commented 2 years ago

in worst_result_on_podium you're disregarding results that podiumed with a DNF mean in rounds where the format is ao5/mo3.

toadfrommariokart64 commented 2 years ago

7x7 is wrong for example, as it's missing the 13:29 single (DNF mean) from this podium: https://www.worldcubeassociation.org/competitions/BrasiliaOpen2009/results/podiums#e777

jonatanklosko commented 2 years ago

This is expected. If we count those cases, then all rankings become by-single and it is much less interesting in my opinion. I added a clarification in 41d7e049da4bc584dd4a007bbe72b39b74e9bf99.