search

jonatanklosko / wca_statistics

Build kit for generating cubing-related rankings
https://jonatanklosko.github.io/wca_statistics
MIT License
18 stars 29 forks source link

Add the FMC country code XW to the list of excluded countries in most_visited_countries.rb #15

Closed OldManLink closed 1 year ago

OldManLink commented 1 year ago

In the statistic most_visited_countries there is a list of FMC "countries" that are to be excluded when counting how many countries a competitor has visited. These are currently XA, XE, XM, and XS.

However, there is a fifth "country", XW, that is currently not excluded, but is counted towards the number of countries a competitor has visited. Two of my friends, AJ Nicholls and Philippe Schwartz have noticed that they have one too many countries against their names, and asked me to take a look.

When I debugged the script I saw that the both had XW among their countries, and when I added XW to the exclude list, they both had the correct number of countries by their names.

jonatanklosko commented 1 year ago

The list has expanded, here are all options, can you include all of them? Also, I believe there are other statistics with the same check, can you search for "XM" and update all of them? Thanks :)

OldManLink commented 1 year ago

Nice one! Fixed now. Checking the other stats for the list.

OldManLink commented 1 year ago

OK, @jonatanklosko I think it's ready now.