search

jonatanklosko / wca_statistics

Build kit for generating cubing-related rankings
https://jonatanklosko.github.io/wca_statistics
MIT License
18 stars 29 forks source link

Added new stat for most comps in a single week #16

Closed OldManLink closed 1 year ago

OldManLink commented 1 year ago

Added a new statistic for the most attended competitions in a single week. A week is considered to start on a Sunday for the purposes of this stat. I'm definitely open to discussing that choice if anyone thinks it was a bad one.

Here's how it looks when rendered in IntelliJ: MostCompsInWeek

jonatanklosko commented 1 year ago

Let's also add the transform as in:

https://github.com/jonatanklosko/wca_statistics/blob/467d78721cab359a4cfb1a5d9b9e915a4fcae12b/statistics/competitions_count_by_week.rb#L24-L31

This way date formatting is consistent.

OldManLink commented 1 year ago

Sounds good. I'll let you know when I've had a chance to try all the suggestions 😎

OldManLink commented 1 year ago

I've added all your suggestions now and the result looks like this: MostCompsInWeek So I'm happy with it now, if you are.

jonatanklosko commented 1 year ago

Looks great! I would change the week to Monday-Sunday as per the other comment and we can ship it.

OldManLink commented 1 year ago

Done!