search

jonatanklosko / wca_statistics

Build kit for generating cubing-related rankings
https://jonatanklosko.github.io/wca_statistics
MIT License
18 stars 29 forks source link

Added some statistics for the fastest time to get all singles/averages. #3

Closed Lykos closed 6 years ago

Lykos commented 6 years ago

Added some statistics for the fastest time to get all singles/averages.

jonatanklosko commented 6 years ago

Hey @Lykos! Thanks for your contribution, it's great to see new stats being added =) You wrote a really nice piece of code in consistent style! I've just pushed an additional commit mostly for the sake of performance. I had an idea that made the queries to run twice as fast (for me locally), timing is very important as I set up Travis to compute the stats daily, and I want to avoid increasing the total time more than it's necessary. In most cases I'd probably just review the code and let you apply the changes, but this time there were more minor changes and I was playing with computation time, so it was convenient for me to just edit stuff, sorry! I will add comments to the commit to justifying the changes, please let me know if they make sense to you. Once you're happy I'll merge this up :tada: Also a general question: did you encounter any issues when setting up the project locally? (Just wanna know whether instructions are clear enough =)).

jonatanklosko commented 6 years ago

Thanks again, @Lykos :shipit: