jonataslaw / getx

Open screens/snackbars/dialogs/bottomSheets without context, manage states and inject dependencies easily with Get.
MIT License
10.21k stars 1.6k forks source link

Get.changeTheme feature was deprecated after v1.13.2. #1060

Closed DarkMarksDoe closed 3 years ago

DarkMarksDoe commented 3 years ago

Description Deprecated code, changing Theme of app using a floatingActionButton from Scaffold. Only Get.changeTheme shows the error, Get.isDarkMode works fine.

Reproduction code

floatingActionButton: FloatingActionButton(
  child: Icon(Icons.add),
    onPressed: () {
      Get.changeTheme(
        Get.isDarkMode ? ThemeData.light() : ThemeData.dark());
      _.increment();
    },
),

Current Message 'Warning: The support for configuring the foreground color of FloatingActionButtons using ThemeData.accentIconTheme has been deprecated. Please use ThemeData.floatingActionButtonTheme instead. See https://flutter.dev/go/remove-fab-accent-theme-dependency. This feature was deprecated after v1.13.2.'

To Reproduce

  1. Clic the floatingActionButton '...'
  2. Clic on Debug Console
  3. See error

Expected behavior Some code is deprecated.

Flutter Version: Flutter 1.22.6 ° Chanel Stable

Getx Version: 3.24.0

Describe on which device you found the bug:

Minimal reproduce code Checked only on Android devices

jonataslaw commented 3 years ago

'Warning: The support for configuring the foreground color of FloatingActionButtons using ThemeData.accentIconTheme has been deprecated. Please use ThemeData.floatingActionButtonTheme instead

Read the warning, it's FloatingActionButton relationed, not GetX.

DarkMarksDoe commented 3 years ago

I saw the Issue #146 Thanks for the answer, greeting for Mexico, land of tacos 🌮

jonataslaw commented 3 years ago

Sure! Off: Me encantan los tacos mexicanos, la cocina mexicana es maravillosa.

DarkMarksDoe commented 3 years ago

Off: No sabía que hablar español, que interesante, y sí, es una tradición muy grande nuestra comida, y algo de miedo con extranjeros probando comidas picosas