SittiphanSittisak
commented
2 years ago I found the case of this issue.
The issue is when opening a dialog, the rouse name will think that is a new route.
Assume the previous route is A and the current route is B and the dialog route is C.
After opening the dialog, the current route will change from B to C and the previous route will change from A to B. This is a basic step but the c route is a dialog and not defined in GetMaterialApp. So, the C route is equivalent to the B route.
At the moment,
the previous route is B => Get.previousRoute = B
the current route is C => Get.currentRoute= C but C = B then Get.currentRoute= B
Did you see that?
Even though we used Ger.back the previous route and the current route still B. Then we can go to route B again because the current route is already B!
For using ModalRoute.of(context)!.settings.name, this is working successfully but this can't use with Get.context. This is a bug!
Please, fix it.
You can see this issue in a new video: https://user-images.githubusercontent.com/59549741/188280286-aa3f0cfe-d63a-4bce-bf9d-433a56e73275.mp4
web example: web exam github_2502
code: main.dart
import 'dart:ui';
import 'package:flutter/material.dart';
import 'package:flutter_test_exam_bug/page/page_github2502.dart';
import 'package:get/get.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({Key? key}) : super(key: key);
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return GetMaterialApp(
scrollBehavior: MyCustomScrollBehavior(),
initialRoute: "/github_2502",
getPages: [
GetPage(name: "/github_2502", page: () => const PageGithub2502()),
GetPage(name: "/github_2502_Page_2", page: () => const PageGithub2502Page2()),
],
);
}
}
class MyCustomScrollBehavior extends MaterialScrollBehavior {
@override
Set<PointerDeviceKind> get dragDevices => {
PointerDeviceKind.touch,
PointerDeviceKind.mouse,
};
}page_github2502.dart
import 'package:flutter/material.dart';
import 'package:get/get.dart';
Future<void> _showMyDialog({required BuildContext context, required Widget child}) async {
return showDialog<void>(
context: context,
builder: (BuildContext context) => child,
);
}
class PageGithub2502 extends StatefulWidget {
const PageGithub2502({Key? key}) : super(key: key);
@override
_PageGithub2502State createState() => _PageGithub2502State();
}
class _PageGithub2502State extends State<PageGithub2502> {
@override
Widget build(BuildContext context) {
Widget dialog_ = Center(
child: ElevatedButton(
onPressed: () async {
print("\n--- Before open the second page ---");
print("previous route :${Get.previousRoute}");
print("current route :${Get.currentRoute}");
print("ModalRoute.of(context)!.settings.name: ${ModalRoute.of(context)!.settings.name}");
await Get.toNamed("/github_2502_Page_2");
print("\n--- After open the second page ---");
print("previous route :${Get.previousRoute}");
print("current route :${Get.currentRoute}");
print("ModalRoute.of(context)!.settings.name: ${ModalRoute.of(context)!.settings.name}");
},
child: const Text("Open second page"))),
openDialogButton_ = ElevatedButton(
onPressed: () async {
print("\n+++ Before open a first dialog +++");
print("previous route :${Get.previousRoute}");
print("current route :${Get.currentRoute}");
print("ModalRoute.of(context)!.settings.name: ${ModalRoute.of(context)!.settings.name}");
await _showMyDialog(context: context, child: dialog_);
print("\n+++ Before open a first dialog +++");
print("previous route :${Get.previousRoute}");
print("current route :${Get.currentRoute}");
print("ModalRoute.of(context)!.settings.name: ${ModalRoute.of(context)!.settings.name}");
},
child: const Text("Open first dialog"));
return Scaffold(backgroundColor: Colors.brown, body: SafeArea(child: Center(child: openDialogButton_)));
}
}
class PageGithub2502Page2 extends StatefulWidget {
const PageGithub2502Page2({Key? key}) : super(key: key);
@override
State<PageGithub2502Page2> createState() => _PageGithub2502Page2State();
}
class _PageGithub2502Page2State extends State<PageGithub2502Page2> {
ButtonStyle buttonStyle = ElevatedButton.styleFrom(primary: Colors.brown);
@override
Widget build(BuildContext context) {
Widget dialog_ = Center(
child: ElevatedButton(
onPressed: () => Navigator.pop(context), child: const Text("I am second dialog"), style: buttonStyle)),
openDialogButton_ = ElevatedButton(
onPressed: () async {
print("\n*** Before open a second dialog ***");
print("previous route :${Get.previousRoute}");
print("current route :${Get.currentRoute}");
print("ModalRoute.of(context)!.settings.name: ${ModalRoute.of(context)!.settings.name}");
await _showMyDialog(context: context, child: dialog_);
print("\n*** After open a second dialog ***");
print("previous route :${Get.previousRoute}");
print("current route :${Get.currentRoute}");
print("ModalRoute.of(context)!.settings.name: ${ModalRoute.of(context)!.settings.name}");
},
child: const Text("Open second dialog"),
style: buttonStyle);
return Scaffold(
appBar: AppBar(backgroundColor: Colors.blueAccent),
backgroundColor: Colors.blueAccent,
body: SafeArea(child: Center(child: openDialogButton_)),
);
}
}
wilhantian
heshesh2010
nullhandler
jonataslaw
ngthailam
It happened when using the
Get.toNamed(). It works fine withNavigator.push()but I needGet.toNamedfor the web app.The
first pagehas a button that will show thefirst dialog. Thefirst dialogwill show the order type button list. When pressing an order type button, the program will find a new order of this type and open thesecond pagewith a new order data. Thesecond pagehas some work to do and this work will open thesecond dialog. After finishing this work, the user will click on the back button back to thefirst pageand find a new order again.The problem is when the
second dialogworks on thesecond page. Thefirst dialogon thefirst pagewill not work.see video example: https://user-images.githubusercontent.com/59549741/184571169-01a030db-59a1-4618-a8c8-003a14e88b10.mp4
web example: web exam github_2502
code example:
flutter doctor: