search

jonataslaw / getx

Open screens/snackbars/dialogs/bottomSheets without context, manage states and inject dependencies easily with Get.
MIT License
10.39k stars 1.63k forks source link

Beware, on Flutter 3.24, the `onPopPage` is deprecated. #3161

Open uzuki-P opened 3 months ago

uzuki-P commented 3 months ago

Describe the bug On Flutter 3.24 the onPopPage is deprecated and change to onDidRemovePage. GetX using onPopPage in here. I don't know what behaviour will change. Just beware OR just use old version of flutter.

Flutter Version: 3.24.0

Getx Version: 4.6.6

uzuki-P commented 3 months ago

Flutter documentation about the API change

fisforfaheem commented 3 months ago

kindly also try, latest version 5 RC6

jonataslaw commented 3 months ago

Thanks for pointing this out.

This impacts very little on the current api, but I am already making these changes. This has a greater impact on those who used the nested routes API, but GetPage will also gain a canPop flag, so you can define this at the time of the routes Since I'm on vacation from work, and working fully on GetX, within 2 or 3 days we will have a major version.

ruanmax commented 3 months ago

The major version will be the version 5 stable?

fisforfaheem commented 3 months ago

Thanks, so much

On Tue, Aug 13, 2024, 5:08 AM Jonny Borges @.***> wrote:

Thanks for pointing this out.

This impacts very little on the current api, but I am already making these changes. This has a greater impact on those who used the nested routes API, but GetPage will also gain a canPop flag, so you can define this at the time of the routes Since I'm on vacation from work, and working fully on GetX, within 2 or 3 days we will have a major version.

— Reply to this email directly, view it on GitHub https://github.com/jonataslaw/getx/issues/3161#issuecomment-2285102851, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRXJSEBFROCEHTMQKX3OHDZRFE7JAVCNFSM6AAAAABMLREMJWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBVGEYDEOBVGE . You are receiving this because you commented.Message ID: @.***>