jonathan-s / django-sockpuppet

Build reactive applications with the django tooling you already know and love.
https://github.com/jonathan-s/django-sockpuppet
MIT License
450 stars 22 forks source link

Triggering a 500 error won't give frontend notice that such an error happened #3

Closed jonathan-s closed 3 years ago

jonathan-s commented 4 years ago

If you are an anonymous user and happen to trigger a 500 error no session key has yet been created. The session key is created first after the page has been rendered. Because of that the consumer sends the error message into an empty void where no frontend will ever receive the message.

Errors that should otherwise be covered when user is logged in, and should be covered by tests.

JulianFeinauer commented 3 years ago

As discussed in discord (just for the notice here).. one issue is that when the exception is raised the WS channel gets closed. So the broadcast to the client is not sent out.

jonathan-s commented 3 years ago

Does not seem to be an issue any more! So closed by #74