search

jonathan-s / django-sockpuppet

Build reactive applications with the django tooling you already know and love.
https://github.com/jonathan-s/django-sockpuppet
MIT License
450 stars 22 forks source link

When using the channel separately to broadcast frontend should listen #44

Closed jonathan-s closed 4 years ago

jonathan-s commented 4 years ago

Type of PR (feature, enhancement, bug fix, etc.)

Bugfix

Description

The issue being that frontend identifies a json structure for the identifier, and when stringifying a json there is no space.

In python when dumping a json there is a space. So there is a mismatch when comparing the identifiers and so no subscription is found.

Checklist

codecov-io commented 4 years ago

Codecov Report

Merging #44 (a980898) into master (4e63613) will decrease coverage by 0.07%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #44      +/-   ##
=========================================
- Coverage    2.68%   2.61%   -0.08%     
=========================================
  Files          12      12              
  Lines         298     306       +8     
  Branches       31      32       +1     
=========================================
  Hits            8       8              
- Misses        290     298       +8
Impacted Files Coverage Δ
sockpuppet/channel.py 0.00% <0.00%> (ø)
sockpuppet/consumer.py 0.00% <0.00%> (ø)
sockpuppet/reflex.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e63613...a980898. Read the comment docs.