jonathan-s / django-sockpuppet

Build reactive applications with the django tooling you already know and love.

https://github.com/jonathan-s/django-sockpuppet

MIT License

450 stars 22 forks source link

Closing socket on page reload #69

Closed jonathan-s closed 3 years ago

jonathan-s commented 3 years ago

Type of PR (feature, enhancement, bug fix, etc.)

Description

When we move to a different page etc, we should probably close the websocket.

Concerns related to this.

Can we re-use a websocket connection.
- We could re-use the websocket connection either through shared web workers or if we use turbo, which doesn't unload the page.

Why should this be added

If we don't close the websocket we might get an overload of sockets that are open but never used etc.

Checklist

[x] Tests are passing
[x] Documentation has been added or amended for this feature / update