jonathan-s / django-sockpuppet

Build reactive applications with the django tooling you already know and love.
https://github.com/jonathan-s/django-sockpuppet
MIT License
450 stars 22 forks source link

Separate linting from tests and fixes actioncable is rejected in Chrome #89

Closed jonathan-s closed 3 years ago

jonathan-s commented 3 years ago

Type of PR (feature, enhancement, bug fix, etc.)

Description

Separates the linting from the tests so it becomes easier to see what is actually failing.

The bigger issue here is that Chrome was rejecting actioncable. What seems to be happening is that the subscription is not created before the websocket is open. So when we try to notify subscriptions there are no subscriptions to notify.

Once we have access to the action cable consumer (which should happen in this PR: https://github.com/hopsoft/stimulus_reflex/pull/444) would could possibly customize this behaviour in a better way so that when the websocket consumer is actually open we would could make sure that the flag on actioncableConsumer is appropriately flagged.

Checklist