jonathan-s / django-sockpuppet

Build reactive applications with the django tooling you already know and love.
https://github.com/jonathan-s/django-sockpuppet
MIT License
450 stars 22 forks source link

Fixed object not found error for detail view #95

Closed sampokuokkanen closed 3 years ago

sampokuokkanen commented 3 years ago

Detail view couldn't find the object, as the kwargs were not being passed to it.

Type of PR (feature, enhancement, bug fix, etc.)

Bug fix, couldn't use DetailView because of missing kwargs.

Description

Fixes the view not having the kwargs it originally had. Minuses: Test server has to be run with python manage.py testserver cypress/fixtures/user.json --noinput (Should update readme, but not sure if this is the correct way of doing this, so haven't updated them yet)

Fixes # (issue)

Why should this be added

This fixes a bug.

Checklist

jonathan-s commented 3 years ago

@sampokuokkanen Thanks a lot for this fix and for writing the integration test for it too!