jonathan-s / django-sockpuppet

Build reactive applications with the django tooling you already know and love.
https://github.com/jonathan-s/django-sockpuppet
MIT License
450 stars 22 forks source link

Refactored reflex.py #96

Closed sampokuokkanen closed 3 years ago

sampokuokkanen commented 3 years ago

view.kwargs was called in the wrong place. It works right now because it's being rescued by the except. Might lead to future bugs, so I thought it should be refactored.

Type of PR (feature, enhancement, bug fix, etc.)

Refactoring

Description

Refactoring of a small part of reflex.py

Why should this be added

My pull request #95 is working because of an except, which is not what I had in mind, and I feel like could lead to future bugs.

I think that doing the class based view stuff and then having an except for none class based ones looks good, but I'm not sure about performance.

Checklist