search

jonathanKingston / containers-theme

Change the theme to match the containers color
https://addons.mozilla.org/en-GB/firefox/addon/containers-theme/
19 stars 9 forks source link

Glitches with Fx 74 & 75 #12

Open hwine opened 4 years ago

hwine commented 4 years ago

Just recently, an uncontained tab stopped getting reset to my default color when switching from a tab with color managed by containers-theme.

STR:

  1. open new window, uses default color 'Y'
  2. open new tab in container 1, uses coloy 'G'
  3. open another new tab in container 2, using color 'B'
  4. toggle between tab 2 & tab 3 -- color changes as expected
  5. toggle between tab 1 and 2 or 3 -- tab 1 will retain color of other tab
  6. decontain tab 2 or 3 -- it will retain color of prior container.

Version 1.0.3

hwine commented 4 years ago

Might be related to this change.

MurzNN commented 4 years ago

Got same issue, seems Firefox change event for switch container tab back to non-container, so this extension not restore default theme.

hwine commented 4 years ago

@MurzNN do you have any pointer to that change? It sounds like this would be a "simple" update, but I don't know my way around extensions or that API at all. I.e. I'm happy to take a shot at a PR, but I don't know where to look.

denisenadal commented 4 years ago

I'm experiencing the same issue.

I think I've got a fix, so I'll be putting up a PR with some changes. I've never worked with Firefox extensions before so I'd be happy to get an extra set of eyes on it

hwine commented 4 years ago

I'm happy to help any way I can, and to test. Thank You!!!

chucklebrother commented 4 years ago

Same thing here, mac OSX FF 74.0, looking forward to a fix, might have to disable for the moment :-(

AnttiBoman commented 4 years ago

FYI, a similar extension still works, here's the code: https://gitlab.com/n0rad/firefox-container-color-toolbar/-/blob/master/background.js . It also changes the default color, though, so I suppose that's the reason.

denisenadal commented 4 years ago

@hwine I would love for you to help with testing! It's been working fine for me during normal day to day usage, but I don't know what any edge cases would look like.

FYI - I don't know what your experience with FF extensions are, but Firefox has a great tutorial here that helped me get started https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension

hwine commented 4 years ago

@denisenadal -- thanks for the link -- I've got it installed, so I'll see if there are any issues today (just starting work). I'll report back at the end of my day.

hwine commented 4 years ago

@denisenadal -- it works just fine -- so good that I forgot I was testing :) Until I updated and lost it (I run Nightly)

denisenadal commented 4 years ago

@hwine thanks for testing and pinging the author!