search

jonathanKingston / ember-cli-sri

Generation of SRI hashes for ember
MIT License
48 stars 15 forks source link

Add fingerprintCheck option and documentation #21

Closed mwpastore closed 8 years ago

mwpastore commented 8 years ago

Final fixes for issue #20!

mwpastore commented 8 years ago

Hrrm, does that normally happen?

jonathanKingston commented 8 years ago

Nope, I think it has before. Could you try committing like a line change or something that does a change without causing linting issues and push -f?

mwpastore commented 8 years ago

Hi Jonathan, I had a quick chat with @rwjblue. He pointed me to this blog post and suggested we either bump the default Ember version or lock the jQuery version. I took the latter approach and it looks like that did the trick!

mwpastore commented 8 years ago

Hi @jonathanKingston, just a friendly poke/prod that this is ready to go, as far as I know. :smiley: Thank you in advance!

jonathanKingston commented 8 years ago

Sounds good enough for me if it is good enough for @rwjblue. I left the options out of ember-cli-sri as I figured it was already complex enough however that isn't a blocker and I probably was wrong. At the time of development SRI was still being standardised so I thought it was best not to confuse people. Thanks!

mwpastore commented 8 years ago

Thank you!