search

jonathanKingston / ember-cli-sri

Generation of SRI hashes for ember
MIT License
48 stars 15 forks source link

ember-cli-gzip should run after rsi, otherwhise the generated hash wi… #7

Closed taylon closed 8 years ago

taylon commented 8 years ago

Hey @jonathanKingston

Today I had a big issue with my Ember app, because after the Chrome 45 release it started to check for SRI and since I use ember-cli-gzip the generated hash was wrong.

The solution is to make sure that ember-cli-gzip runs after ember-cli-sri. After that everything works great =D

A lot of people that use this combination will probably have a surprise as users start to update to Chrome 45.

I also opened a pull request for ember-cli-gzip, I think this should be reinforced in both sides.

jonathanKingston commented 8 years ago

Yup this looks correct (I have not used the gzip lib). I held of hunting down libraries that would have this form of issue as it likely won't scale so well as a solution (I'm considering proposing named hooks which might fix this better).

I'll test this more tonight as going to be pushing a patch for the encoding issue.

jonathanKingston commented 8 years ago

:+1: thank you so much for this!