search

jonathanKingston / ember-cli-sri

Generation of SRI hashes for ember
MIT License
48 stars 15 forks source link

Adds integrity for all except `vendor.js`, `frontend.js` and `frontend.css` #8

Closed YoranBrondsema closed 8 years ago

YoranBrondsema commented 8 years ago

Hi,

I enabled SRI according to the instructions. The weird thing is, it adds the integrity attribute for all stylesheets and scripts except for vendor.js, frontend.js and frontend.css. I'm not really sure why these are treated differently. Any idea?

Yoran

jonathanKingston commented 8 years ago

See: #5

Chrome encoding is breaking unicode sometimes; the code doesn't work on those files to prevent breaking for now.

On Thu, Sep 17, 2015 at 10:06 AM Yoran Brondsema notifications@github.com wrote:

Hi,

I enabled SRI according to the instructions. The weird thing is, it adds the integrity attribute for all stylesheets and scripts except for vendor.js, frontend.js and frontend.css. I'm not really sure why these are treated differently. Any idea?

Yoran

— Reply to this email directly or view it on GitHub https://github.com/jonathanKingston/ember-cli-sri/issues/8.

YoranBrondsema commented 8 years ago

OK I see, that choice makes sense. Thanks for the quick reply!

jonathanKingston commented 8 years ago

Closing as #5 is a better issue for this and the Chrome team is working on this. (Thank you for checking here :+1: )