search

jonathanKingston / sea-containers

Sidebar for managing container tabs
https://addons.mozilla.org/en-GB/firefox/addon/sea-containers/
Mozilla Public License 2.0
32 stars 6 forks source link

Sidebar refresh #39

Open grahamperrin opened 7 years ago

grahamperrin commented 7 years ago

Issue

Sea containers does not refresh when expected.

Examples

Following changes of icons, from fingerprints to circles:

2017-08-01 05 07 40 icons

Following deletion of containers:

2017-08-01 05 14 04 deleted

Suggestion

If the Sea containers sidebar is open before the Containers menu is used to edit (or delete) a container, then Sea containers should refresh after each such use of Containers.

grahamperrin commented 7 years ago

Similarly: the sidebar is outdated following a Context Plus switch away from a user-named container, to Default:

2017-09-01 07 38 42

Firefox 55.03, FreeBSD-CURRENT, Sea Containers 0.5, other extensions include Vertical Tabs Reloaded.

Workaround: close then reopen the sidebar.

From https://github.com/mozilla/testpilot-containers/issues/772#issuecomment-325520124 (2017-08-29) under inconsitencies of colour and name · Issue #772 · mozilla/testpilot-containers:

… we just added the API hooks to observe container changes. …

– so I guess that a fix will be in an update to Sea Containers 👍

justfortherec commented 6 years ago

Edit: I see there is already #11 for the issue I am describing. Please disregard my comment.

Probably related: The counter next to container names is never decremented.

Steps to reproduce:

Expected behaviour: Tab count next to container name decrements.

Actual behaviour: Tab counts does not update.

As described above: Closing Sea containers sidebar and opening it again resets counters to correct values.