Implement search

[jonathanKingston]

Search could be controlled through a shortcut to open the sidebar and focus a search box.

Filtering and opening all relevant container panels whilst highlighting them.

[grahamperrin]

… shortcut …

The usual: beware of conflicts. Consider the shortlist of points at https://github.com/mozilla/testpilot-containers/issues/245#issuecomment-292862635

I'd prefer a method of presenting the search interface that allows the user to assign a shortcut, without assigning a shortcut by default.

… Filtering and opening all relevant container panels …

Will titles and URLs of pages be matched? (Anything more, or less?)

[jonathanKingston]

Will titles and URLs of pages be matched? (Anything more, or less?)

Both. Searching in page etc will be super buggy slow and noisy.

The sidebar will have Ctrl+Shift+Period to open, I'm going to make search the default when this lands.

[jonathanKingston]

@grahamperrin I just pushed a work in progress patch. It filters fine, however this isn't super useful alone.

Required is:

• [ ] Keyboard navigation to go through the items easily
• [ ] Auto expand all matching containers
• [ ] Esc key / perhaps other to cancel
• [ ] UI improvements for icons and position
• [ ] Auto focus on open

[jonathanKingston]

The logic used is:

• Split each term used "keyword keyword"
• Lowercase each keyword
• Match url and title against keyword
• If all keyword matches then tab is shown

[grahamperrin]

… a work in progress patch …

Thanks, I don't see the feature, am I missing something?

NB for me this is theoretical:

• I wouldn't actually use a search feature in Sea containers
• I treat Sea containers as complementary to extensions such as Conex.

[tradewatcher]

The option to show a filter textbar at the top of sidebar is an idea but for me it would be useless. Adress bar have a great search function.