search

jonathanawesome / blanket

blanket is a modern and opinionated Wordpress starter theme. blanket assumes you're familiar with the following: Advanced Wordpress, ACF, non-jQuery DOM manipulation, NPM, Webpack, SASS.
1 stars 0 forks source link

Ignore dist? #5

Closed gblakeman closed 5 years ago

gblakeman commented 5 years ago

I typically set a /build or /dist directory to be ignored by git and not checked in to the repo. I mainly do this since I generally rely on build/CI servers for code checks and deployment and consider the build directory as something that can be removed and rebuilt at any time.

gblakeman commented 5 years ago

Thoughts @jonathanawesome? Would you be open to ignoring it, do you tend to build locally and commit the build as part of the project repo?

jonathanawesome commented 5 years ago

I use blanket as a true starter theme because most Wordpress projects need more than just the theme under version control (plugins, languages, favicon, PWA bits in root). I keep a local Wordpress install solely for the purpose of running/updating/modifying blanket and ensuring that it works with the latest version of WP. For new projects the zip gets pulled down to the theme directory, I do work using npm run dev inside the theme, and commit and branch from the wider repo.

jonathanawesome commented 5 years ago

That said, your changes are awesome if you're using CI and wider project coverage isn't necessary. Your fork is looking super modern...it's the Tesla of WP themes! Open to doing a parallel release branch situation. What do you think?

gblakeman commented 5 years ago

I figured you were committing the wider Wordpress project and deploying it.

I'm open to a parallel release branch. Let me get the setup a bit more dialed for my project and see how it fleshes out before I commit code on your end.

gblakeman commented 5 years ago

I can close this for now…