search

jonathanbossenger / aw-divi-social

Add social media icons to Divi header and footer
GNU General Public License v3.0
3 stars 1 forks source link

Any chance this will be revived for current WordPress + Divi versions? #1

Open bhadaway opened 2 years ago

jonathanbossenger commented 2 years ago

Hi @bhadaway, thanks for logging the issue.

Do you perhaps have screenshots/details of what doesn't work in the current versions of WordPress + Div?

bhadaway commented 2 years ago

It just simply doesn't load into the Divi settings anymore. WordPress is extremely stable, and changes very slowly over the years, so my guess would be that Divi changed something that severed the way you originally hooked into it. Or, it could be something as simple as a compatibility issue with PHP 8.

Honestly, I didn't dig into the matter that deeply because it's been 3 years since you last updated it; I just assumed that it was no longer being developed and it was obvious to you that it no longer worked. However, based on your reaction, that doesn't seem to be the case, so I'll debug and see if I can pull up any specific errors and get back to you.

Thanks

jonathanbossenger commented 2 years ago

Got it thanks.

Ever since I open-sourced the code three years ago, I didn't think anyone used the plugin anymore, so I wasn't aware of any Divi changes. I'd be happy to get it updated and available on the official plugin repo.

bhadaway commented 2 years ago

It's odd that after all these years, Divi still doesn't have more social media options added in, but thems the breaks, so your plugin still has a valuable purpose. Rather than digging around testing and gathering error messages, I'm just going to email you some working code for you to review (a PR wouldn't be useful in this instance).

bhadaway commented 2 years ago

Email sent.