search

jonathanchu / atom-one-dark-theme

Atom One Dark - An Emacs port of the Atom One Dark theme from Atom.io.
GNU General Public License v3.0
255 stars 52 forks source link

js2-mode: Fix function parameter colors #20

Closed whitlockjc closed 7 years ago

whitlockjc commented 7 years ago

There is currently no js2-mode support and so there are colors being set by js2-mode that are making it through instead of being styled by this package. This commit includes the only deviation I can find right now, which is function parameters. js2-mode sets the js2-function-param face to SeaGreen but it should be atom-one-dark-mono-1 based on what Atom itself uses.

This commit does not add comprehensive js2-mode support but I did go through and look for discrepancies and only found this one.

whitlockjc commented 7 years ago

I've found another js2-mode discrepancy so I will just create a new PR with js2-mode support. Sorry about that.