whitlockjc
commented
7 years ago Example
Discrepancies
Below are the noticeable discrepancies between Atom and Emacs (first occurrence type):
- Line 863: Atom styles the brackets around the type while Emacs does not
- Line 865: Atom does not style the contents within the return type brackets while Emacs does
- Line 867: Atom does not style the alias name while Emacs does
- Line 871: Atom does not style object properties within a literal but Emacs does (Emacs does not distinguish between object property literal names and object property reference names)
- Line 879: Atom styles the variable name but Emacs does not (Emacs does not distinguish between a variable declaration name and a variable reference name)
- Line 890: Atom styles keywords even if they are property names while Emacs does not (Emacs is in the right here)
- Line 899: Atom styles number literals while Emacs does not
jonathanchu
This commit adds initial support for js2-mode. This is not a 100% complete representation but that is more due to the differences between how Atom and Emacs theme in general and less about the work. For the most part this is straight forward but there is support for face-remapping to allow for a more accurate theme. This can be disabled if necessary and is documented in the source.
For the face-remapping, I copied the same approach I used in my own Atom Dark theme for emacs: https://github.com/whitlockjc/atom-dark-theme-emacs/blob/master/atom-dark-theme.el
Note: I was unable to make the code within the face-remapping hook work with your
atom-one-dark-with-color-variablesmacro so I just copied/pasted the style (with comment) instead of referencing the theme-specific color by name. If I can figure this out, I will update the PR.